Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PreserveText preg_split with $limit null #2

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

glady
Copy link
Collaborator

@glady glady commented Oct 13, 2022

Description

Deprecated in PHP 8.1

  • preg_split(): Passing null to parameter #3 ($limit) of type int is deprecated

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

Deprecated in PHP 8.1
- preg_split(): Passing null to parameter mraspe#3 ($limit) of type int is deprecated
- -1 and 0 had same effect in versions before
@glady
Copy link
Collaborator Author

glady commented Oct 13, 2022

Hint: original repository also set -1 here.

@mraspe mraspe merged commit 451787c into mraspe:develop Oct 14, 2022
glady pushed a commit to glady/PHPWord that referenced this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants